Copy template ireq to set hash info #11021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of mutating the ireq, we create a new one to assign additional information on.
|
@uranusjr I've checked this PR - tests on pip-tools still failing. |
|
Does #11019 avoid the issue? I’m trying to gauge whether there is a problem of this particular implementation, or perhaps we’re solving the wrong thing here. |
github-actions
bot
added
the
needs rebase or merge
|
Going to go ahead and close this, since it has merge conflicts that haven't been resolved in a while. Please feel welcome to file a new PR or to reopen and update this one! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of mutating the ireq, we create a new one to assign additional information on.
Alternative fix to #11019. Instead of relying on
copy.copy(InstallRequirementhas too much legacy), we use the good-ol'make_install_req_from_linkinstead. Also since we only need this information on the candidate, we can move the assignments into the candidate-creating function instead.cc @atugushev