fix: Use proper subdirectory syntax for pip url fragments #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use the correct syntax for url fragments with pip of the form python -m pip install "pkg @ vcs+protocol://repo_url/#subdirectory=pkg_dir" - c.f. https://pip.pypa.io/en/stable/topics/vcs-support/#url-fragments * Revises PR pypa#1207 Co-authored-by: sinoroc <[email protected]>
|
@pradyunsg @sinoroc sorry about the noise and for not being more diligent on the syntax in PR #1207, but this is ready for review. |
sinoroc
approved these changes
Feb 14, 2023
pradyunsg
approved these changes
Feb 14, 2023
|
Thanks @matthewfeickert for the fixes, and @sinoroc for spotting this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipof the formreq @ urlsyntax to install from remote VCS #1207