cygwinccompiler: Split CC env var before passing to subprocess #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazka
force-pushed
the
fix-cc-command-line
branch
from
cce5106 to
2e6d057
Compare
4113bc3 added support for clang by respecting the CC env variable. The content of the env var gets passed to check_output() as the compiler executable. But CC is not just a path to an executable but a command line, such as "ccache gcc" which makes checkout_output() fail in those cases because it will try to look for "ccache gcc" in PATH instead of "ccache". To fix the issue use shlex to parse the command line before passing it to check_output().
lazka
force-pushed
the
fix-cc-command-line
branch
from
2e6d057 to
629f8ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4113bc3 added support for clang by respecting the CC env variable.
The content of the env var gets passed to check_output() as the compiler
executable. But CC is not just a path to an executable but a command line,
such as "ccache gcc" which makes checkout_output() fail in those cases because
it will try to look for "ccache gcc" in PATH instead of "ccache".
To fix the issue use shlex to parse the command line before passing it to
check_output().
Co-authored-by: Christoph Reiter [email protected]
Signed-off-by: Naveen M K [email protected]
Part of #34