Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove twisted #972

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Remove twisted #972

merged 2 commits into from
Jul 26, 2022

Conversation

janiversen
Copy link
Collaborator

No description provided.

@janiversen janiversen marked this pull request as draft July 23, 2022 16:35
@janiversen janiversen marked this pull request as ready for review July 24, 2022 06:10
@janiversen
Copy link
Collaborator Author

@dhoomakethu would you please have a look at this.

I am aware that schedulers is not removed, I want to do that in a separate PR, because it affects a lot of files.

@janiversen
Copy link
Collaborator Author

Big breath !!! this is going to make some waves in the pond.

@janiversen janiversen merged commit d594b87 into pymodbus-dev:dev Jul 26, 2022
@janiversen janiversen deleted the remove_twisted branch July 26, 2022 21:55
@shajek
Copy link

shajek commented Aug 18, 2022

Hello, i think that this change broke updating_server.py example

@janiversen
Copy link
Collaborator Author

This PR have been merged for quite a while and thus closed. This is not a place to discuss new problems, open an issue if you have problem but please do tell why it is broken and add a log showing the problem.

As always Pull requests are more than welcome.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants