Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove easy_install and ez_setup #964

Merged
merged 3 commits into from
Jul 20, 2022
Merged

remove easy_install and ez_setup #964

merged 3 commits into from
Jul 20, 2022

Conversation

imba-tjd
Copy link
Contributor

Since dev branch requires 3.8+, there is no need to use ez_setup

janiversen
janiversen requested changes Jul 20, 2022
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
doc/INSTALL Outdated Show resolved Hide resolved
doc/INSTALL Outdated Show resolved Hide resolved
doc/INSTALL Outdated Show resolved Hide resolved
janiversen
janiversen approved these changes Jul 20, 2022
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

If interested in similar tasks I can help you get started., we need f.x. to update the parameter documentation.

@janiversen janiversen merged commit 3942d79 into pymodbus-dev:dev Jul 20, 2022
@janiversen
Copy link
Collaborator

Have a look at:
#966
I think that could be interesting for you (do make change all files in 1 PR).

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janiversen janiversen janiversen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imba-tjd @janiversen