Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update classifiers for pypi #907

Merged
merged 1 commit into from
May 22, 2022
Merged

Update classifiers for pypi #907

merged 1 commit into from
May 22, 2022

Conversation

janiversen
Copy link
Collaborator

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented May 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@janiversen
Copy link
Collaborator Author

@dhoomakethu I believe this should do it. At least now all classifiers in the list you referenced.

@janiversen janiversen merged commit b4a091b into pymodbus-dev:dev May 22, 2022
@janiversen janiversen deleted the classifiers branch May 22, 2022 11:12
@dhoomakethu
Copy link
Contributor

Yes, I have the same modified file , the new error is

Content received from server:
<html>
 <head>
  <title>400 The description failed to render in the default format of reStructuredText. See https://pypi.org/help/#description-content-type for more information.</title>
 </head>
 <body>
  <h1>400 The description failed to render in the default format of reStructuredText. See https://pypi.org/help/#description-content-type for more information.</h1>
  The server could not comply with the request since it is either malformed or otherwise incorrect.<br/><br/>
The description failed to render in the default format of reStructuredText. See https://pypi.org/help/#description-content-type for more information.


 </body>
</html>
HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
The description failed to render in the default format of reStructuredText. See https://pypi.org/help/#description-content-type for more information.

@dhoomakethu
Copy link
Contributor

Working on it

dhoomakethu
dhoomakethu reviewed May 22, 2022
View reviewed changes
setup.cfg
Operating System :: OS Independent :: Linux :: Windows :: Mac OS
Programming Language :: Python :: 3.8
Topic :: System :: Networking :: Utilities :: SCADA :: Modbus
Operating System :: OS Independent :: Linux
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no Operating System :: OS Independent :: Linux , we can use Operating System :: POSIX :: Linux

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the working diff

index 6d4e6433..94c61680 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -9,17 +9,26 @@ platforms        = 'Linux', 'Mac OS X', 'Win'
 description      = "A fully featured modbus protocol stack in python"
 keywords         = 'modbus, asyncio, scada, client, server, simulator'
 long_description = file: README.rst, CHANGELOG.rst, LICENSE
-url              = 'https://github.com/riptideio/pymodbus/'
-classifiers      =
+url              = https://github.com/riptideio/pymodbus/
+classifiers      =
     Development Status :: 4 - Beta
-    Programming Language :: Python :: 3.8 :: 3.9 :: 3.10
     Environment :: Console
-    Framework :: Twisted :: Tornado :: Asyncio
-    Intended Audience :: Developers :: Modbus testers
+    Framework :: Twisted
+    Framework :: AsyncIO
+    Intended Audience :: Developers
     License :: OSI Approved :: BSD License
-    Operating System :: OS Independent :: Linux :: Windows :: Mac OS
+    Operating System :: POSIX :: Linux
+    Operating System :: Unix
+    Operating System :: MacOS :: MacOS X
+    Operating System :: OS Independent
+    Operating System :: Microsoft
     Programming Language :: Python :: 3.8
-    Topic :: System :: Networking :: Utilities :: SCADA :: Modbus
+    Programming Language :: Python :: 3.9
+    Programming Language :: Python :: 3.10
+    Programming Language :: Python :: 3.11
+    Programming Language :: Python :: 3.12
+    Topic :: System :: Networking
+    Topic :: Utilities
 project_urls     =
     Source Code  = https://github.com/riptideio/pymodbus
     Bug Reports  = https://github.com/riptideio/pymodbus/issues
(END)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me. But should we really announce 3.11 and 3.12 ? I have not tested 3.11 and know there are problems with 3.12

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you commit the changes directly ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will do it once I figure out the issue with the long_description

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have update README.rst to reflect that we now are at dev4.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool , I have the release published to Pypi https://pypi.org/project/pymodbus/3.0.0.dev4/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, more testing for me 😃

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dhoomakethu dhoomakethu dhoomakethu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janiversen @dhoomakethu