Add support for byte strings in the device information fields #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iterate over the list of identity values and append the bytes if the field is a byte string, append the encoded string otherwise.
dhoomakethu
reviewed
Dec 16, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to emulate a modbus device that has non ASCII data in the vendor name part of the device information. The library cannot correctly encode this, because when encoding this info it is encoded as utf-8. For example, a vendor name of "\xF0\x12\x34" ends up as b"\xC3\xB0\x12\x34" in the encoded payload.
This PR changes the encoding of the device information fields to support both
bytesobjects andstrobjects.The appropriate unit tests have been added.