Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove python2 compatibility code #564

Merged
merged 9 commits into from
Mar 29, 2022
Merged

Remove python2 compatibility code #564

merged 9 commits into from
Mar 29, 2022

Conversation

swamper123
Copy link
Collaborator

Drop the Python2 and <3.6 code

@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dhoomakethu
Copy link
Contributor

@swamper123 Apologies for the long delay, looks like you have commited venv as well with this PR. Would be great If you could clean this up.

alexrudd2
alexrudd2 reviewed Oct 4, 2021
View reviewed changes
README.rst Outdated Show resolved Hide resolved
@swamper123
Copy link
Collaborator Author

@dhoomakethu I just recognised that I had this PR still open. 😅
I guess I have to rebase some stuff since then and will clean it up (hopefully successfull) in the near future. ^^

@swamper123
Copy link
Collaborator Author

FYI: At the moment I am still busy with other things going on. So it will either be at the end of the year or mid January, unti I can lay my hands on that PR again.

@swamper123 swamper123 mentioned this pull request Dec 20, 2021
Closed
fbeitler added 2 commits February 2, 2022 06:57
Remove Python2 checks
7ba6a49 
Remove Python2 code snippets
Fix smaller errors
7dfac6f 
 Remove Python2 from checks, CI stuff and more
@swamper123 swamper123 force-pushed the remove_python2_compatibility_code branch from 8d2649c to 7dfac6f Compare February 2, 2022 07:34
@swamper123
Copy link
Collaborator Author

I think I got the most stuff uptodate again.
Not sure, what the failing report tries to tell me.
If something is still missing/not correct: Help is always wanted ;)

@swamper123 swamper123 force-pushed the remove_python2_compatibility_code branch from c5e8c16 to 3f6d951 Compare February 2, 2022 15:15
@dhoomakethu
Copy link
Contributor

dhoomakethu commented Feb 2, 2022 •
edited
Loading

~~It could be the coverage that has dropped down. ~~
Actually its the tests on mac and windows failing to start.

@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swamper123 swamper123 marked this pull request as draft February 3, 2022 07:48
@swamper123
Copy link
Collaborator Author

swamper123 commented Feb 3, 2022 •
edited
Loading

The stuff may be green, but I am still not happy about this, but don't know where to continue a.t.m.:

====================== 474 passed, 19 skipped in 42.13s =======================
D:\a\pymodbus\pymodbus\.tox\pypy37\site-packages\_pytest\mark\structures.py:552: RuntimeWarning: coroutine 'AsyncioModbusSerialClient.connect' was never awaited
  seen.update(self.parent.keywords)
D:\a\pymodbus\pymodbus\.tox\pypy37\site-packages\_pytest\mark\structures.py:552: RuntimeWarning: coroutine 'ReconnectingAsyncioModbusTcpClient._reconnect' was never awaited
  seen.update(self.parent.keywords)

I don't know if that happens in branch 3.0.0 as well, because the logs are to old and have been removed.
Not sure if it is the mockstuff or a factory thing...

@swamper123 swamper123 marked this pull request as ready for review February 7, 2022 07:16
@swamper123
Copy link
Collaborator Author

Would be happy about every review. :)

@swamper123
Copy link
Collaborator Author

I know that this is a bigger PR, but a step in an easier to handle direction in the future.
Still glad about every review that would be made.

@sonarcloud
Copy link

sonarcloud bot commented Mar 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dhoomakethu
Copy link
Contributor

I am biting the bullet and merging this to 3.0.0 branch and will release 3.0.0.dev3 soon

@dhoomakethu dhoomakethu merged commit 6a86d58 into pymodbus-dev:3.0.0 Mar 29, 2022
This was referenced Mar 31, 2022
Closed
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexrudd2 alexrudd2 alexrudd2 left review comments

Assignees
No one assigned
Labels
help wanted hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swamper123 @dhoomakethu @alexrudd2