Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypy
flags theelse
branch as unreachable because theisinstance
check always passes. I think this happened in ce67df9 but went unnoticed because the function isn't annotated.pymodbus/pymodbus/server/async_io.py
Lines 162 to 172 in 214c7ed
So this PR deletes the entire conditional, as well as the now-useless
reset_frame
flag.Also, it cleans up the docstring mangled by 18aa463