Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type hints for port and timeout #1147

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Fix type hints for port and timeout #1147

merged 1 commit into from
Oct 28, 2022

Conversation

alexrudd2
Copy link
Collaborator

8b24d39 had an error. port should have remained int

Closes #1142

janiversen
janiversen approved these changes Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@janiversen janiversen merged commit 61d9e9a into pymodbus-dev:dev Oct 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janiversen janiversen janiversen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minimum client timeout 1s?
2 participants
@alexrudd2 @janiversen