[deprecation] Make 'OutputLine' require a fixed number of args #8474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
the
Maintenance
DanielNoord
previously approved these changes
Mar 21, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8474 +/- ##
==========================================
+ Coverage 95.81% 95.92% +0.10%
==========================================
Files 174 174
Lines 18334 18358 +24
==========================================
+ Hits 17567 17609 +42
+ Misses 767 749 -18
|
DanielNoord
previously approved these changes
Mar 21, 2023
This comment has been minimized.
This comment has been minimized.
|
I'm going to fix the coverage properly in #8484 , we need to have test for the updating of functional output, it can break anytime and it would with the current change. Drafting this. |
Pierre-Sassoulas
force-pushed
the
output-line-functional-tests
branch
from
1d5a1d8 to
aa10d07
Compare
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
force-pushed
the
output-line-functional-tests
branch
from
a446504 to
d4e78f0
Compare
This comment has been minimized.
This comment has been minimized.
Co-authored-by: DaniΓ«l van Noord <[email protected]>
Pierre-Sassoulas
force-pushed
the
output-line-functional-tests
branch
from
670df4b to
0c80e1e
Compare
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 0c80e1e |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Enacting planned deprecation.