Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when open is called with an integer mode #6415

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Fix crash when open is called with an integer mode #6415

merged 1 commit into from
Apr 21, 2022

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
✓ 🐛 Bug fix

Description

Closes #6414

@Pierre-Sassoulas Pierre-Sassoulas added Crash 💥 A bug that makes pylint crash Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels Apr 20, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.13.8 milestone Apr 20, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2197995047

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.129%
Totals Coverage Status
Change from base Build 2197363334: 0.0%
Covered Lines: 15721
Relevant Lines: 16526
💛 - Coveralls

@DanielNoord
Copy link
Collaborator

Should we take this opportunity to introduce unsupported-file-mode?

@Pierre-Sassoulas
Copy link
Member Author

What would be the difference with bad-open-mode ?

@DanielNoord
Copy link
Collaborator

😅

Other suggestion: Let's merge _check_open_encoded and _check_open_mode. In both we're inferring the mode argument and duplicating some code.
Can't we do _check_open_call?

@Pierre-Sassoulas
Copy link
Member Author

👍 but let's do the refactor in another 2.14 only MR, I don't want to deal with cherry-pick conflicts on the maintenance branch 😄

@DanielNoord
Copy link
Collaborator

Are you assigning yourself to that refactor? If not, perhaps open an issue for 2.14?

@Pierre-Sassoulas Pierre-Sassoulas merged commit ab3ad06 into pylint-dev:main Apr 21, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the fix-issue-6414 branch April 21, 2022 09:18
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request Apr 21, 2022
Merged
@Pierre-Sassoulas
Copy link
Member Author

Opened #6422 (work in progress right now)

@Pierre-Sassoulas Pierre-Sassoulas added Backported and removed Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels May 2, 2022
Pierre-Sassoulas added a commit that referenced this pull request May 2, 2022
@Pierre-Sassoulas
Fix crash when open is called with an integer mode (#6415)
f1d930b 
Closes #6414
Pierre-Sassoulas added a commit that referenced this pull request May 2, 2022
@Pierre-Sassoulas
Fix crash when open is called with an integer mode (#6415)
7022d23 
Closes #6414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
Backported Crash 💥 A bug that makes pylint crash
Projects
None yet
Milestone
2.13.8
Development

Successfully merging this pull request may close these issues.

Exception thrown when checking code that passes an integer mode= to open
3 participants
@Pierre-Sassoulas @coveralls @DanielNoord