-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove primer test on black-primer #5924
Conversation
black-primer was removed from black repository, so primer test on this directory has been removed to prevent the CI from failing. See psf/black#2924
@teobouvard Thanks for noticing this and coming with the quick PR! Could you remove the changelog though? The primer is only really used for us internally to check if we don't make any changes that crash on other projects. There is (currently) not really a reason for us to tell people about this in the Changelog. |
Pull Request Test Coverage Report for Build 1989366817
💛 - Coveralls |
It's the second time today that the CI times out on Python 3.10 tests, any ideas why ? |
We suspect it has something to do with the cores of the Linux runner. We test our parallel run mode while assuming the test machine has two cores available. Previously we assumed (wrongly) that 10 cores were available, which meant that the tests timed out much more often. We have debated whether we should remove the timeout for the tests. Personally I think it is still fine. Although annoying, the current situation is somewhat better than having runners being occupied for over an hour doing a test suite that is taking unnecessarily long. Also, all maintainers know that this is an issue and now not to look into it too much when it occurs on a specific PR. In the long term we would like to get a solution here, but after many attempts I'm really stuck for any solutions. The documentation from Github says that all Linux runners should have two cores and all tests pass fine locally, but for some reason on certain runners there are issues. I haven't found any discussion online as of yet that could allude to what is going on here. |
True, and since this is not really an issue that can be debugged easily, I think keeping timeouts is reasonable. Thanks for the information. |
CONTRIBUTORS.txt
if you are a new contributor.doc/whatsnew/<current release.rst>
.Description
black-primer
was removed from black repository, so primer test on thisdirectory has been removed to prevent the CI from failing.
See psf/black#2924