Pylint reporter cleanup #5003
Merged
Pylint reporter cleanup #5003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove dead code that was always failing and replace it by an attribute directly.
Pierre-Sassoulas
added
the
Maintenance
Pull Request Test Coverage Report for Build 1233911269
💛 - Coveralls |
cdce8p
approved these changes
Sep 14, 2021
Co-authored-by: Marc Mueller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This create a file for the
BaseWriterthat was hidden in the init file and was creating circular import when trying to add typing in #5004 . Also remove a piece of code that was always failing,(probably a misunderstanding at some point). It should provide slightly better performances by not try-catching an error and calling lower on the class name multiple time..