-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False negative for consider-using-augmented-assign for nested dicts #8959
Labels
False Negative 🦋
No message is emitted but something is wrong with the code
Needs PR
This issue is accepted, sufficiently specified and now needs an implementation
Milestone
Comments
EugeneZelenko
added
the
Needs triage 📥
Just created, needs acknowledgment, triage, and proper labelling
label
Aug 15, 2023
Pierre-Sassoulas
added
False Negative 🦋
No message is emitted but something is wrong with the code
Needs PR
This issue is accepted, sufficiently specified and now needs an implementation
and removed
Needs triage 📥
Just created, needs acknowledgment, triage, and proper labelling
labels
Aug 15, 2023
Thanks for opening the issue, I can reproduce on main. |
Interesting, I think I might be able to get in a PR for this in a few days. |
Same is true for regular
|
crazybolillo
added a commit
to crazybolillo/pylint
that referenced
this issue
Aug 18, 2023
Assignments on dictionaries which used the same slices were not generating `consider-using-augmented-assign` messages. This has been fixed. Closes pylint-dev#8959.
crazybolillo
added a commit
to crazybolillo/pylint
that referenced
this issue
Aug 18, 2023
Assignments on dictionaries which used the same subscripts were not generating `consider-using-augmented-assign` messages. This has been fixed. Closes pylint-dev#8959.
It seems like it also applies for lists: kiwi = [1, 2]
kiwi[0] = kiwi[0] + 1 # [consider-using-augmented-assign] |
crazybolillo
added a commit
to crazybolillo/pylint
that referenced
this issue
Aug 18, 2023
Assignments on dictionaries or lists which used the same subscripts were not generating `consider-using-augmented-assign` messages. This has been fixed. Closes pylint-dev#8959.
crazybolillo
added a commit
to crazybolillo/pylint
that referenced
this issue
Aug 22, 2023
Assignments on dictionaries or lists which used the same subscripts were not generating `consider-using-augmented-assign` messages. This has been fixed. Closes pylint-dev#8959.
crazybolillo
added a commit
to crazybolillo/pylint
that referenced
this issue
Aug 22, 2023
Assignments on dictionaries or lists which used the same subscripts were not generating `consider-using-augmented-assign` messages. This has been fixed. Closes pylint-dev#8959.
crazybolillo
added a commit
to crazybolillo/pylint
that referenced
this issue
Aug 22, 2023
Assignments on dictionaries or lists which used the same subscripts were not generating `consider-using-augmented-assign` messages. This has been fixed. Closes pylint-dev#8959.
crazybolillo
added a commit
to crazybolillo/pylint
that referenced
this issue
Aug 22, 2023
Assignments on dictionaries or lists which used the same subscripts were not generating `consider-using-augmented-assign` messages. This has been fixed. Closes pylint-dev#8959.
PR is ready, wonder if you guys can take a look? Thanks |
@crazybolillo: Thank you for quick implementation! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
False Negative 🦋
No message is emitted but something is wrong with the code
Needs PR
This issue is accepted, sufficiently specified and now needs an implementation
Bug description
consider-using-augmented-assign
did not catch next situations:Configuration
No response
Command used
Pylint output
************* Module pylint_test pylint_test.py:1:0: C0114: Missing module docstring (missing-module-docstring) ------------------------------------------------------------------- Your code has been rated at 6.67/10 (previous run: 10.00/10, -3.33)
Expected behavior
Warning should be shown.
Pylint version
OS / Environment
No response
Additional dependencies
No response
The text was updated successfully, but these errors were encountered: