Changes the way flat attribute of numpy array is inferred
#830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hippo91
changed the title
flat attribute of numpy array is inferred
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
This PR solves the pylint bug pylint-dev/pylint#3640.
It was due to the fact that in the
brain_numpy_ndarraytheflatattribute wasNone.Rigorously it should be a
numpy.flatiterinstance, but as for now this class doesn't exist in the brain, i choose to replace it by just anumpy.ndarray. This way, iteration and indexation on the return value of theflatattribute is allowed.Type of Changes
Related Issue
Closes pylint-dev/pylint#3640