Upgrade mypy to 0.940 #1466
Upgrade mypy to 0.940 #1466
Conversation
| @@ -1222,7 +1222,7 @@ def test_type_comments_with() -> None: | |||
| """ | |||
| with a as b: # type: int | |||
| pass | |||
| with a as b: # type: ignore | |||
| with a as b: # type: ignore[name-defined] | |||
There was a problem hiding this comment.
Didn't saw that those these here are inside code blocks 😅
Doesn't matter now I guess.
There was a problem hiding this comment.
It's interesting that mypy picks up on those. Do you know if code in code blocks is checked? If not, this option also probably shouldn't?
There was a problem hiding this comment.
It's interesting that
mypypicks up on those. Do you know if code in code blocks is checked? If not, this option also probably shouldn't?
Mypy didn't notice those. I just searched for type: ignore and looked which ones didn't have error codes 😄
There was a problem hiding this comment.
If I'm not mistaken they did. I think I saw an error message about not having the error specified for these.
There was a problem hiding this comment.
Hmm 🤔 I just removed the comment and ran mypy. Didn't saw it.
Under the hood mypy uses ast parsing and this would be just one string node. So hard to imagine that it would mark it.
There was a problem hiding this comment.
Probably my memory messing up 😅
Steps
Description
Type of Changes
Related Issue
Can't merge yet as the
pre-commitmypy mirror hasn't been updated yet, see: https://github.com/pre-commit/mirrors-mypy