Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing shape parameter to numpy methods #1450

Merged
merged 9 commits into from
Mar 9, 2022
Merged

Add missing shape parameter to numpy methods #1450

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
99fc19e
Fix false positive for ``shape`` parameter of ``numpy.zeros_like`` me…
mbyrnepr2 Mar 7, 2022
2abefd3
The default value of `shape` is `None`
mbyrnepr2 Mar 8, 2022
0e26cae
`shape` parameter is also missing for `full_like` & `ones_like`
mbyrnepr2 Mar 8, 2022
061db90
Add a unittest to check for expected parameters for numpy methods
mbyrnepr2 Mar 8, 2022
6298b28
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 8, 2022
0bc5171
Merge branch 'main' of https://github.com/PyCQA/astroid into pylint_i…
mbyrnepr2 Mar 9, 2022
85bb56e
Use Daniël's improvements:
mbyrnepr2 Mar 9, 2022
c3504e0
Update tests/unittest_brain_numpy_core_numeric.py
DanielNoord Mar 9, 2022
aeb1bf8
Last changes
cdce8p Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ Release date: TBA

Closes #1410

* Fix false positive for ``shape`` parameter of ``numpy.zeros_like`` method.

Closes PyCQA/pylint#5871


What's New in astroid 2.10.1?
=============================
Expand Down
2 changes: 1 addition & 1 deletion astroid/brain/brain_numpy_core_numeric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def numpy_core_numeric_transform():
"""
# different functions defined in numeric.py
import numpy
def zeros_like(a, dtype=None, order='K', subok=True): return numpy.ndarray((0, 0))
def zeros_like(a, dtype=None, order='K', subok=True, shape=0): return numpy.ndarray((0, 0))
def ones_like(a, dtype=None, order='K', subok=True): return numpy.ndarray((0, 0))
def full_like(a, fill_value, dtype=None, order='K', subok=True): return numpy.ndarray((0, 0))
"""
Expand Down