Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix frame() error on inferred node #1263
Fix frame() error on inferred node #1263
Changes from 32 commits
fff4db4
2cab065
8952c64
4ea13b2
42ce9f4
4629c93
9b2c483
27c1707
1b59f00
54bcb59
7bee391
9e55d84
9da479c
9fb55c5
dac07c6
3163665
08014ed
67281cb
3bee4f5
db901ce
a01e510
410445b
1d6dc24
a3b2db9
4a1a4ad
b9f0ee0
42b787e
9be8a89
08bcd08
79bb6c2
76faa99
1f1f7e7
c68db00
8bbba41
7ad182c
1fe3c11
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea behind it was to only allow two specific call options:
node.frame()
node.frame(future=True)
It doesn't really make sense to add
future=None
or evenfuture=False
if you don't support the future case.--
After your comment I noticed that we probably need to add overloads here to make that happen.
This needs to be added to all frame definitions as overloads aren't inherited.
The overloads for
statement()
also need to be fixed, but I can do that in a separate PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably also need a
pylint: disable
comment, as there is a false-positive with thearguments-differ
message and overloads: pylint-dev/pylint#5264There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, the PR to fix the
node.statement()
overload typing: #1308There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out the overload idea doesn't actually work as I though. Sorry for the confusion. The default with
None
is needed for the parent calls.I've already opened another PR to fix the
node.statement
calls #1317.