Dynamic service names & domain #387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
|
FWIW - If you need a DNS change on |
|
Marking this as inactive for now. |
fubarhouse
added
the
inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been asked switch pygmy over to use
pygmy.siteas a default for users, so that's what this done.It also contributes to the public strategy amazee.io have previously announced where the amazee.io branding is separated from their products - such as Lagoon.
This PR will switch
amazeeio-container names topygmy-whilst still using existing container names when the networkamazeeio-networkstill exists. Custom container names via thepygmy,namelabel are still working as expected and are tested.I've also added a piece to the readme so that users who need to run applications on
docker.amazee.iosubdomains can do so unhindered - in addition to the dynamic discovery. It would cause me problems as I often use thecleancommand instead of thedowncommand - which does in fact delete the docker network.