Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Stats compute perf #449

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve Stats compute perf #449

wants to merge 1 commit into from
+6 −3

Conversation

Kh4L
Copy link

@Kh4L Kh4L commented Sep 9, 2024

This PR improves performance of StatType.compute by calling np.hstack only when needed.

Before change:

$ time python  gnn_node.py --dataset=rel-hm --task=user-churn --epochs 1 --max_steps_per_epoch 250
[...]
real    3m17.517s
user    3m19.252s
sys     0m6.757s

After change:

$ time python  gnn_node.py --dataset=rel-hm --task=user-churn --epochs 1 --max_steps_per_epoch 250
[...]
real    1m43.020s
user    1m45.716s
sys     0m6.022s

@weihua916
Copy link
Contributor

Thanks.
@Kh4L could you pass the test? @akihironitta could you help review/update this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihironitta akihironitta Awaiting requested review from akihironitta

At least 1 approving review is required to merge this pull request.

Assignees

@Kh4L Kh4L

Labels
data performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kh4L @weihua916 @akihironitta