Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare more models across frame and tabular #444

Merged
merged 30 commits into from
Sep 6, 2024
Merged

Conversation

wsad1
Copy link
Member

@wsad1 wsad1 commented Sep 2, 2024

Follow up to #398.
Adds an option to compare FTTransformer accross pytorch tabular and frame.

CUDA:
Frame: 43.7 it/s
Tabular: 40.15 it/s

@wsad1 wsad1 changed the base branch from master to yyuan/add-pytorch-tabular-comparison-script September 2, 2024 23:43
@wsad1 wsad1 requested a review from yiweny September 3, 2024 02:44
@wsad1 wsad1 self-assigned this Sep 3, 2024
Copy link
Contributor

@yiweny yiweny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

benchmark/pytorch_tabular_benchmark.py Show resolved Hide resolved
benchmark/pytorch_tabular_benchmark.py Outdated Show resolved Hide resolved
benchmark/pytorch_tabular_benchmark.py Outdated Show resolved Hide resolved
@wsad1 wsad1 requested a review from akihironitta September 4, 2024 22:10
Copy link
Member

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from yyuan/add-pytorch-tabular-comparison-script to master September 6, 2024 19:02
@wsad1 wsad1 merged commit b28e9a3 into master Sep 6, 2024
13 checks passed
@wsad1 wsad1 deleted the tab_frame_comp_2 branch September 6, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants