Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use identity instead of equality when possible #10712

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Oct 25, 2024

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Oct 25, 2024
Copy link

cloudflare-workers-and-pages bot commented Oct 25, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8566d16
Status: ✅  Deploy successful!
Preview URL: https://7e9a8636.pydantic-docs.pages.dev
Branch Preview URL: https://identity-over-equality.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hq bot commented Oct 25, 2024

CodSpeed Performance Report

Merging #10712 will not alter performance

Comparing identity-over-equality (8566d16) with main (13979e9)

Summary

✅ 44 untouched benchmarks

Copy link
Contributor

github-actions bot commented Oct 25, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _generate_schema.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty hard to review such a large diff, but after much pondering, I've decided we should move forward with this ✅

@sydney-runkle sydney-runkle merged commit 19f7d41 into main Oct 25, 2024
54 checks passed
@sydney-runkle sydney-runkle deleted the identity-over-equality branch October 25, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants