Transport improvements #29
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `BaseTransport.read()` has got better logging with regards to processing steps. Also, start and end chars now use `constants` instead of duplcicated literals * `BaseTransport.read()` and `BaseTransport.simple_read()` have been reworked to allow receiving end chars with no start chars previously seen - that might happen when ACK/NACK received
present, there might be cases when data is empty e.g. when ACK/NACK received
(`bytes.hex()` takes no arguments in that version)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseTransport.read()has got better logging with regards to processing steps. Also, start and end chars now useconstantsinstead of duplicated literalsBaseTransport.read()andBaseTransport.simple_read()have been reworked to allow receiving end chars with no start chars previously seen - that might happen when ACK/NACK received