Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop MonadZero file, class, and instance #76

Merged
merged 5 commits into from
Mar 16, 2022
Merged

Drop MonadZero file, class, and instance #76

merged 5 commits into from
Mar 16, 2022

Conversation

JordanMartinez
Copy link
Contributor

Description of the change

Fixes #67


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez JordanMartinez added purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump. labels Feb 15, 2022
@JordanMartinez
Copy link
Contributor Author

🏓 @thomashoneyman

This is where the MonadZero class is defined. Once this merges, all other libraries that have such instances will also need those instances removed to compile (e.g. contrib libraries).

@JordanMartinez
Copy link
Contributor Author

So, should we wait until the end before merging this PR?

package.json Outdated Show resolved Hide resolved
@thomashoneyman
Copy link
Member

No, I think this is fine to go ahead with. The contrib libraries won't depend on the new version of control until they're also being updated for 0.15, so it's not much of an issue.

Co-authored-by: Thomas Honeyman <[email protected]>
@JordanMartinez JordanMartinez merged commit 05e4445 into purescript:master Mar 16, 2022
@JordanMartinez JordanMartinez deleted the dropMonadZero branch March 16, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated MonadZero instance (v0.15.0 PS)
2 participants