Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to PureScript v0.15.0 #59

Merged
merged 11 commits into from
Mar 22, 2022
Merged

Update to PureScript v0.15.0 #59

merged 11 commits into from
Mar 22, 2022

Conversation

JordanMartinez
Copy link
Contributor

Description of the change

Backlinking to purescript/purescript#4244

Updates project to compile on v0.15.0 PureScript.

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez JordanMartinez added type: breaking change A change that requires a major version bump. purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 labels Mar 22, 2022
@JordanMartinez
Copy link
Contributor Author

🏓 @thomashoneyman

thomashoneyman
thomashoneyman approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@thomashoneyman thomashoneyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting — I must have missed this in the purs tidy updates. Any chance you could add purs-tidy with the standard .tidyrc.json, run it to format everything, and add the purs tidy check src test line to CI?

@JordanMartinez
Copy link
Contributor Author

Can that be done as a separate PR? It'll mess up this diff otherwise.

@thomashoneyman
Copy link
Contributor

Yes, absolutely.

@thomashoneyman thomashoneyman merged commit 0acdb46 into purescript-contrib:main Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JordanMartinez @thomashoneyman