Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for BoundedEnum #22

Merged
merged 3 commits into from
Nov 10, 2016
Merged

Conversation

jacereda
Copy link
Contributor

@jacereda jacereda commented Nov 10, 2016

Sorry for the unimaginative law names, I hope someone else can come up with nicer ones.

@jacereda
Copy link
Contributor Author

I guess this will fail until purescript-enums is tagged.

@garyb
Copy link
Member

garyb commented Nov 10, 2016

Also need to add the dependency I think!

@jacereda
Copy link
Contributor Author

Doh! I had a bower link... >= 2.0.1?

@garyb
Copy link
Member

garyb commented Nov 10, 2016

Thanks!

@garyb garyb merged commit 304cbbf into purescript-contrib:master Nov 10, 2016
@jacereda
Copy link
Contributor Author

Just curious, why do you use sudo: required in the travis setup? Don't you prefer the container-based environment?

@garyb
Copy link
Member

garyb commented Nov 11, 2016

Should I make a release now, or are there any other checks you're working on at the moment?

Just curious, why do you use sudo: required in the travis setup? Don't you prefer the container-based environment?

The trusty image requires it, and that's pretty much essential for PureScript projects, for some reason they build awfully without it - take 10-100x longer and sometimes stall forever.

@garyb
Copy link
Member

garyb commented Nov 11, 2016

I think trusty is container based too.

@jacereda
Copy link
Contributor Author

jacereda commented Nov 11, 2016

Looks like they have a beta: https://docs.travis-ci.com/user/trusty-ci-environment/

@jacereda
Copy link
Contributor Author

I think I can write Enum tomorrow, let's wait a bit.

@garyb
Copy link
Member

garyb commented Nov 11, 2016

Okidoke, thanks! We can try the trusty beta thing in that PR too perhaps :)

@jacereda
Copy link
Contributor Author

I'll open a separate request for the trusty beta, but build times are roughly the same and boot time is almost instantaneous. Things aren't as nice when trying to build the purescript compiler itself, I get failures due to lack of disk space and also the build seems slower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants