Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAT-1382] : Fixing CI failure due to rubocop #380

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Conversation

rajat-puppet
Copy link
Contributor

@rajat-puppet rajat-puppet commented Sep 11, 2023

Summary

Fixing CI failure due to rubocop

Additional Context

  • New version released in rubocop-rspec (v2.24.0) caused regression in linting.
Split RSpec/FilePath into RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat. RSpec/FilePath cop is enabled by default, the two new cops are pending and need to be enabled explicitly. (@ydah)
Add RSpec/MetadataStyle and RSpec/EmptyMetadata cops.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@Ramesh7 Ramesh7 marked this pull request as ready for review September 11, 2023 15:30
@Ramesh7 Ramesh7 requested a review from a team as a code owner September 11, 2023 15:30
Ramesh7
Ramesh7 previously approved these changes Sep 11, 2023
@rajat-puppet rajat-puppet force-pushed the CAT-1382-Fix-CI-Pipeline branch from 835e516 to b32d16c Compare September 13, 2023 12:55
@Ramesh7 Ramesh7 merged commit 2aa306d into main Sep 14, 2023
11 checks passed
@Ramesh7 Ramesh7 deleted the CAT-1382-Fix-CI-Pipeline branch September 14, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants