-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container-gcp-* templates #413
Conversation
Question for reviewers: Should these templates create a new container registry, or use the registry that's enabled on the GCP project? Something tells me we should create a new one, but I'm not finding many examples (of ours or in general) that actually do that; most seem push to |
@cnunciato What is the behavior of the corresponding templates for the other providers? I would try to match that behavior here for consistency among templates across providers (where possible). |
e02d0e5
to
496d821
Compare
496d821
to
f11b2b3
Compare
@scottslowe Near as I can tell, there's not really a way to create multiple registries per project, like there is with other providers; from the docs, it looks like you can push to up to four location-based hosts, but that's it: https://cloud.google.com/container-registry/docs/overview So I think what we have here should suffice for purpose of the template -- but would love to hear whether @timbohiatt has any additional guidance here for us. |
Merging on @scottslowe's in Slack. |
Hey @cnunciato @scottslowe thanks for summoning me to another great PR; I see this is now merge complete. Sorry about the delay. However for what it is worth here are a few thoughts. That might help for further Example and Template developments.
My personal suggestion would be all examples or templates later on that require the creation of a Docker Image registry housed on Google Cloud simply use Artifact Registry. I think it would save a headache late on. Plus the examples of creating a Artifact Registry Repository for Docker Images could easily be replicated for Maven, YUM, NPM ect should those examples be required later on. Additionally the URL structures for Container Registry and Artifact Registry are quite different. gcr.io vs us-docker.pkg.dev where "us" is the region and "docker" is the registry type. Also, I am not sure how this stacks up with other Cloud Providers however at this time Cloud Run only supports Container Images that come from within Container Registry and or Artifact Registry. One final consideration from my point. As previously mentioned the Creation of either Artifact Registry or Container registry both require the enablement of Google Cloud API for use with IaC or from within Cloud Console. Transitioning Container Registry to Artifact Registry Public Docs: Whole lot of information there. Sorry it's late I don't think for this particular PR it would change any outcomes. However I think its context is helpful for potentially future content. |
This change adds new templates for
container-gcp-{typescript,python,go,csharp}
. Apps return JSON responses using common language-specific frameworks. Excludes YAML for now, asdocker:Image
is not yet supported.Fixes https://github.com/pulumi/devrel-team/issues/173.