Implement a blocklist and improve errors when unsupported resources are created #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFriel
added
the
impact/no-changelog-required
iwahbe
requested changes
Apr 21, 2022
AaronFriel
force-pushed
the
aaronfriel/157
branch
from
440c627 to
924e8e0
Compare
iwahbe
approved these changes
Apr 25, 2022
pkg/pulumiyaml/packages.go
Outdated
| "kubernetes:yaml:ConfigGroup": "https://github.com/pulumi/pulumi-kubernetes/issues/1971", | ||
| } | ||
|
|
||
| var exists = struct{}{} |
There was a problem hiding this comment.
Nit: It seems strange to alias struct{}{}. I think it requires less mental effort to read the literal (struct{}{}).
There was a problem hiding this comment.
Replaced with literals, which apparently can just be {}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't support resources that are implemented by the SDK in each language of the resource provider instead of in the provider binary. This technique is also known as an "overlay" when generating SDKs.
We emit some error messages with references to the issues to support these in YAML indirectly:
See:
Imagea real CustomResource pulumi-docker#132For Helm Chart resources, we recommend the user try the Helm Release resource instead.
Fixes #157