-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove double-slashes to fix examples docs generation #875
Conversation
Diff for pulumi-random with merge commit 3f83c14 |
Diff for pulumi-azuread with merge commit 3f83c14 |
Diff for pulumi-gcp with merge commit 3f83c14 |
pulumi-docker reached an edge case in docsgen that uses a template with invalid syntax (double-slashes) switched double-slash to single-slash to make syntax valid
3f553e6
to
3267eae
Compare
Diff for pulumi-azure with merge commit 3f83c14 |
Diff for pulumi-random with merge commit baf0ab0 |
Diff for pulumi-azuread with merge commit baf0ab0 |
Diff for pulumi-gcp with merge commit baf0ab0 |
Diff for pulumi-azure with merge commit baf0ab0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 1088 should also include java
, no?
Co-authored-by: Aaron Friel <[email protected]>
Diff for pulumi-random with merge commit 81cdac5 |
Diff for pulumi-azuread with merge commit 81cdac5 |
Diff for pulumi-gcp with merge commit 81cdac5 |
Diff for pulumi-azure with merge commit 81cdac5 |
Diff for pulumi-azuread with merge commit 1a813b3 |
Diff for pulumi-random with merge commit 1a813b3 |
Diff for pulumi-gcp with merge commit 1a813b3 |
…erate schema and SDKs
Diff for pulumi-azure with merge commit 1a813b3 |
* Remove shortcode from example docsgen because the bridge adds it * Pull in bridge changes from pulumi/pulumi-terraform-bridge#875; regenerate schema and SDKs * update archived library
Fix was resolved pulumi/pulumi-docker#524 |
Ah oops, i closed the wrong PR here, we do need to merge this one |
Diff for pulumi-random with merge commit 1bf4ed9 |
Diff for pulumi-azuread with merge commit 1bf4ed9 |
Diff for pulumi-gcp with merge commit 1bf4ed9 |
Diff for pulumi-azure with merge commit 1bf4ed9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Can we have a test or an explanation why a test isn't possible/practical and how it's been tested thanks. |
Oh I see it's a P0. In that case let's backlog the test and get it in. |
@t0yv0 we need to keep this branch alive temporarily |
Apologies! Got it. |
we can delete this branch since the schema file is already generated |
for pulumi/docs#8672
pulumi-docker reached an edge case in docsgen that uses a template with invalid syntax (double-slashes, changed to single-slash should be the way to go according to docs team)