Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove double-slashes to fix examples docs generation #875

Merged
merged 3 commits into from
Mar 8, 2023

Conversation

jazzyfresh
Copy link
Contributor

@jazzyfresh jazzyfresh commented Mar 8, 2023

for pulumi/docs#8672

pulumi-docker reached an edge case in docsgen that uses a template with invalid syntax (double-slashes, changed to single-slash should be the way to go according to docs team)

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Diff for pulumi-random with merge commit 3f83c14

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Diff for pulumi-azuread with merge commit 3f83c14

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Diff for pulumi-gcp with merge commit 3f83c14

pulumi-docker reached an edge case in docsgen that uses a template
with invalid syntax (double-slashes)

switched double-slash to single-slash to make syntax valid
@jazzyfresh jazzyfresh force-pushed the jazzyfresh/docsgen-examples-fix-8672 branch from 3f553e6 to 3267eae Compare March 8, 2023 04:50
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Diff for pulumi-azure with merge commit 3f83c14

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Diff for pulumi-random with merge commit baf0ab0

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Diff for pulumi-azuread with merge commit baf0ab0

@jazzyfresh jazzyfresh requested a review from sean1588 March 8, 2023 05:00
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Diff for pulumi-gcp with merge commit baf0ab0

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Diff for pulumi-azure with merge commit baf0ab0

Copy link
Contributor

@guineveresaenger guineveresaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 1088 should also include java, no?

Co-authored-by: Aaron Friel <[email protected]>
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Diff for pulumi-random with merge commit 81cdac5

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Diff for pulumi-azuread with merge commit 81cdac5

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Diff for pulumi-gcp with merge commit 81cdac5

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Diff for pulumi-azure with merge commit 81cdac5

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Diff for pulumi-azuread with merge commit 1a813b3

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Diff for pulumi-random with merge commit 1a813b3

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Diff for pulumi-gcp with merge commit 1a813b3

guineveresaenger added a commit to pulumi/pulumi-docker that referenced this pull request Mar 8, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Diff for pulumi-azure with merge commit 1a813b3

guineveresaenger added a commit to pulumi/pulumi-docker that referenced this pull request Mar 8, 2023
* Remove shortcode from example docsgen because the bridge adds it

* Pull in bridge changes from pulumi/pulumi-terraform-bridge#875; regenerate schema and SDKs

* update archived library
@jazzyfresh jazzyfresh closed this Mar 8, 2023
@jazzyfresh
Copy link
Contributor Author

Fix was resolved pulumi/pulumi-docker#524

@jazzyfresh
Copy link
Contributor Author

Ah oops, i closed the wrong PR here, we do need to merge this one

@jazzyfresh jazzyfresh reopened this Mar 8, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Diff for pulumi-random with merge commit 1bf4ed9

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Diff for pulumi-azuread with merge commit 1bf4ed9

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Diff for pulumi-gcp with merge commit 1bf4ed9

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Diff for pulumi-azure with merge commit 1bf4ed9

Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@t0yv0
Copy link
Member

t0yv0 commented Mar 8, 2023

Can we have a test or an explanation why a test isn't possible/practical and how it's been tested thanks.

@t0yv0
Copy link
Member

t0yv0 commented Mar 8, 2023

Oh I see it's a P0. In that case let's backlog the test and get it in.

@t0yv0 t0yv0 merged commit 1b40a7e into master Mar 8, 2023
@t0yv0 t0yv0 deleted the jazzyfresh/docsgen-examples-fix-8672 branch March 8, 2023 13:55
@jazzyfresh jazzyfresh restored the jazzyfresh/docsgen-examples-fix-8672 branch March 8, 2023 17:03
@jazzyfresh
Copy link
Contributor Author

@t0yv0 we need to keep this branch alive temporarily

@t0yv0
Copy link
Member

t0yv0 commented Mar 8, 2023

Apologies! Got it.

@jazzyfresh
Copy link
Contributor Author

we can delete this branch since the schema file is already generated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants