Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cascading secrets to Deployment settings #475

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

IaroslavTitov
Copy link
Contributor

Summary

Testing

  • Manual test

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@IaroslavTitov IaroslavTitov marked this pull request as ready for review December 13, 2024 01:31
@IaroslavTitov IaroslavTitov merged commit 7bb4d37 into main Dec 13, 2024
25 checks passed
@IaroslavTitov IaroslavTitov deleted the iaro/cascade branch December 13, 2024 20:41
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (49003fc) to head (fc87d1c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #475   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pulumi-bot
Copy link

This PR has been shipped in release v0.27.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeploymentSettings doesn't handle EnvironmentVariables if it's a secret and fails/ignore silently
3 participants