Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting a commit for the git source doesn't work for the DeploymentSettings resource #469

Closed
komalali opened this issue Dec 10, 2024 · 1 comment · Fixed by #470
Closed

Setting a commit for the git source doesn't work for the DeploymentSettings resource #469

komalali opened this issue Dec 10, 2024 · 1 comment · Fixed by #470
Assignees
@komalali
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Milestone
0.114

Comments

@komalali
Copy link
Member

The commit property is not propagated to the API call and returns an error like Bad Request: at least commit or branch are required even with the commit property is set.
@komalali komalali added the kind/bug Some behavior is incorrect or out of spec label Dec 10, 2024
@komalali komalali added this to the 0.114 milestone Dec 10, 2024
@komalali komalali self-assigned this Dec 10, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Dec 10, 2024
@komalali komalali removed the needs-triage Needs attention from the triage team label Dec 10, 2024
@komalali komalali mentioned this issue Dec 10, 2024
Merged
komalali added a commit that referenced this issue Dec 10, 2024
@komalali
Ensure commit is propagated to API call (#470)
d8e3f2a 
Fixes #469
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Dec 10, 2024
@pulumi-bot
Copy link

This issue has been addressed in PR #470 and shipped in release v0.27.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@komalali komalali

Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.114
Development

Successfully merging a pull request may close this issue.

Ensure commit is propagated to API call pulumi/pulumi-pulumiservice
2 participants
@komalali @pulumi-bot