Update GitHub Actions workflows. #3383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulumi-bot
added
the
impact/no-changelog-required
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3383 +/- ##
==========================================
- Coverage 41.17% 41.14% -0.03%
==========================================
Files 85 85
Lines 12764 12764
==========================================
- Hits 5255 5252 -3
- Misses 7120 7122 +2
- Partials 389 390 +1 ☔ View full report in Codecov by Sentry. |
github-merge-queue bot
pushed a commit
to pulumi/ci-mgmt
that referenced
this pull request
Dec 19, 2024
p-k has a weird bug pulumi/pulumi-kubernetes#3382 where we aren't able to depend on the correct "Sentinel" check. This updates the native sentinel job to more closely match the bridged one: https://github.com/pulumi/ci-mgmt/blob/1243b9e2dff8ae4d4391591bcec61a38daeac0af/provider-ci/test-providers/aws/.github/workflows/run-acceptance-tests.yml#L87-L109 Other native providers don't have this problem, so I don't actually think this will resolve the issue, but it should at least help rule out any permission weirdness. Edit: OK I ran this against p-k here pulumi/pulumi-kubernetes#3383 and suddenly the Sentinel check is available to us! So it does seem there's something wonky about the job's settings. Before  After 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated by the rollout-single-native-provider-workflow workflow in the pulumi/ci-mgmt repo, from commit 0fde7cbb0da9104cfdb68e69fe5d0ddee2bc0ec7.