fix: properly determine list objects in schemagen #3205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
blampe
approved these changes
Sep 14, 2024
Yes, I'll add to this PR next week! |
rquitales
force-pushed
the
rquitales/fix-patch-for-list
branch
from
08cb054 to
cc6ef93
Compare
rquitales
added
the
impact/no-changelog-required
rquitales
force-pushed
the
rquitales/fix-patch-for-list
branch
from
cc6ef93 to
d33c9ff
Compare
rquitales
commented
Sep 16, 2024
| @@ -693,6 +705,14 @@ func createGroups(definitionsJSON map[string]any, allowHyphens bool) []GroupConf | |||
|
|
|||
| return fmt.Sprintf("%s/%s", gStripped, v) | |||
| } | |||
|
|
|||
| // These resources are hard-coded as lists as they do not adhere to the normal conventions. | |||
There was a problem hiding this comment.
The list is nested under the resources and groups field instead of items for these two kinds.
rquitales
commented
Sep 16, 2024
|
|
||
| -- kinds -- | ||
| - k8sversion.test.TestResource | ||
| - k8sversion.test.TestResourceNotRealList |
There was a problem hiding this comment.
A custom resource that ends in List, but is not a List kind.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3205 +/- ##
==========================================
+ Coverage 38.60% 40.84% +2.23%
==========================================
Files 84 84
Lines 9866 9876 +10
==========================================
+ Hits 3809 4034 +225
+ Misses 5695 5459 -236
- Partials 362 383 +21 ☔ View full report in Codecov by Sentry. |
blampe
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRDs can have types that end in
List. These are not actually List resources, so we should not rely on name alone to determine this. Instead, we should follow the rules set out in the conventions guide to determine is a Kind is meant to be a List kind.