Unit tests for Await logic (Creation) #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2797 +/- ##
==========================================
+ Coverage 23.41% 24.72% +1.30%
==========================================
Files 48 48
Lines 9629 9647 +18
==========================================
+ Hits 2255 2385 +130
+ Misses 7224 7106 -118
- Partials 150 156 +6 ☔ View full report in Codecov by Sentry. |
EronWright
changed the title
EronWright
force-pushed
the
eronwright-issue-2539-pre1
branch
from
b03b0d1 to
64fd212
Compare
rquitales
reviewed
Jan 31, 2024
|
LGTM overall. I'd echo @rquitales' comments, but this looks like a nice addition to the test suite! 🎉 |
EronWright
added
the
impact/no-changelog-required
rquitales
approved these changes
Feb 1, 2024
EronWright
force-pushed
the
eronwright-issue-2539-pre1
branch
from
a0edac7 to
5ce341d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR implements unit tests for the await logic, i.e. the flow of hitting the API server (with retry), then invoking the registered awaiter to poll for success, then refreshing the live object.
Related issues (optional)
Closes #2791