Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Run cluster-scoped resource tests in series #2527

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

rquitales
Copy link
Member

Proposed changes

Runs 2 non-parallelized tests as sub-tests to prevent test flakes since they touch the same cluster-scoped CRDs.

Related issues (optional)

Fixes: #2525

@rquitales rquitales added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@rquitales rquitales requested review from lblackstone and a team August 8, 2023 09:08
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

// TestCRDs runs 2 sub tests that cannot be parallelized as they touch
// the same cluster-scoped CRD. This is required until we can run tests
// in parallel with different clusters (tracked by: https://github.com/pulumi/pulumi-kubernetes/issues/2243).
// The tests run are: `testAccPrometheusOperator` and `testRancher`.
Copy link
Member

@iwahbe iwahbe Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L527 isn't necessary.

Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice solution!

@rquitales rquitales merged commit 3ff9f38 into master Aug 9, 2023
@rquitales rquitales deleted the rquitales/serialize-tests branch August 9, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[flake] TestAccPrometheusOperator can conflict with TestRancher
3 participants