[TS] Pass provider to yaml resources #1996
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
|
I've opened #2005 with fixes for all SDKs and relevant test cases. Thanks again for getting the ball rolling here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This plumbs a provider through a few yaml flows that were implicitly relying on the default provider.
This only covers TS for now -- from the linked issues it seems this might still affect some of the other languages.
I'm not sure how to best test this -- locally it resolved an issue I was seeing with
yaml.ConfigGroup, but I haven't verified kustomize, helm/v2, etc. I was thinking of settingdisable-default-providerson a couple of the CI examples, but that feels pretty blunt...Related issues (optional)
Refs #1938 #1945