-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm 3 not installing custom CRDs #1023
Comments
Just ran into this myself. It is expected that Pulumi would install the CRDs automatically the same as helm would. I think the big fix would be to use the |
Yes, this is correct. We'd need to plumb that option through to the SDK. |
Could this be related to #993? In my case it's not installing any resources at all. |
@rhyek I don´t think so. This issue is related with Custom CRDs and the reason is well identified by the missing support for the "include crds" flag. I have installed like 5 or 6 Helm charts into my cluster without any problem. |
I can confirm that with pulumi v2.0.0 and pulumi-kubernetes==2.0.0 (Python SDK), CRDs are not installed. I tried to install the traefik chart https://github.com/containous/traefik-helm-chart/tree/master/traefik |
We're going to add this to the provider, but if you come here and you're trying to install a chart with CRDs, a workaround is to install them using
|
@jaxxstorm, I did precisely that. Nevertheless, as you can imagine, it is inconvenient to download the CRDs locally and keep track of the changes in the target repository.
|
This PR adds a mechanism to detect if helm v3 is being used when the chart is rendered. If it is, it includes the `--include-crds` flag so that the CRDs are rendered as part of the YAML stream. Fixes #1023
# This is the 1st commit message: Use include-crds flags when using helm v3 This PR adds a mechanism to detect if helm v3 is being used when the chart is rendered. If it is, it includes the `--include-crds` flag so that the CRDs are rendered as part of the YAML stream. Fixes #1023 # The commit message #2 will be skipped: # Remove version hack # The commit message #3 will be skipped: # Remove unneeded execSync options
This PR adds a mechanism to detect if helm v3 is being used when the chart is rendered. If it is, it includes the `--include-crds` flag so that the CRDs are rendered as part of the YAML stream. Fixes #1023
This should be available in the next release of the provider! |
@jaxxstorm, I've updated pulumi-kubernetes to 2.2.0, but CRDs are still not installed by default. |
which version of helm are you using locally? |
@jaxxstorm |
@jaxxstorm, CRDs from this chart https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-prometheus-stack do not get installed first, so dependant resources fail. |
I'm having the same issue as @dz-pyps using pulumi-kubernetes, python and helm 3. I'm trying to install argocd helm chart which contains CRDs and CRs. CRDs don't get installed and all the CRs fail to be installed because the definitions are missing. |
Problem description
I am trying to install cert-manager with Helm and Pulumi.
I have this configuration:
The custom CRDs provided by the chart are not being installed. I have exactly the same setup in Terraform and it works, so I guess it´s an issue of Pulumi Helm resource and not the chart.
If I understood correctly Pulumi uses
helm template
under the hood. I think the issue might be that the command doesn´t allow specifying the "include crds" flag. (see https://github.com/helm/helm/pull/7138/files)The text was updated successfully, but these errors were encountered: