Embed sdk version #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update schema to add respectSchemaVersion. - Use `pulumi package gen-sdk` so we can set the version (install pulumi CLI in local folder). - Update python build to match other providers.
Does the PR have any schema changes?Looking good! No breaking changes found. |
iwahbe
approved these changes
May 28, 2024
|
|
||
| # Pulumi for codegen | ||
|
|
||
| .pulumi/bin/pulumi: PULUMI_VERSION := $(shell cat .pulumi.version) |
There was a problem hiding this comment.
I'm always scared that this will never get bumped, but its no worse then we have in other places.
There was a problem hiding this comment.
Yup, I think we just need this as part of the scheduled upgrade job. Have added an issue to track this: pulumi/ci-mgmt#940
Me and @blampe have been debating this area also in pulumi/pulumi-docker-build#68 and my efforts so far have been to standardise on this very simple style of installing an isolated copy of pulumi, and I hope we can also move all bridged providers to this too once the docs issues are resolved and we no longer have to modify the schema for each language.
78 tasks
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable respectSchemaVersion:
pulumi package gen-sdkso we can set the version (install pulumi CLI in local folder).Tidy old generation code: