Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tests #26

Closed
iwahbe opened this issue Aug 28, 2023 · 0 comments · Fixed by #250
Closed

Add Tests #26

iwahbe opened this issue Aug 28, 2023 · 0 comments · Fixed by #250
Assignees
@rshade
Labels
help wanted Extra attention is needed kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@iwahbe
Copy link
Member

iwahbe commented Aug 28, 2023

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

We should add tests for this component. At the moment we don't have any CI to ensure quality here.

Affected area/feature
@iwahbe iwahbe added help wanted Extra attention is needed kind/enhancement Improvements or new features labels Aug 28, 2023
@blampe blampe mentioned this issue Apr 17, 2024
Merged
blampe added a commit that referenced this issue Apr 18, 2024
@blampe
Manage workflows with ci-mgmt (#38)
25fee43 
This updates our GitHub workflows to use ones generated by ci-mgmt, and then updates Makefile targets and other pieces to build cleanly against those workflows.

Fixes #28
Fixes #27

Note the repo has some examples but these aren't hooked up to CI testing yet -- that is #26.
@rshade rshade self-assigned this Dec 6, 2024
rshade added a commit that referenced this issue Dec 11, 2024
@rshade
Adding in providertest files for typescript and python, fixes #26
8078509
rshade added a commit that referenced this issue Dec 11, 2024
@rshade
Adding in providertest files for typescript and python, fixes #26
dda60d1
rshade added a commit that referenced this issue Dec 11, 2024
@rshade
Adding in providertest files for typescript and python, fixes #26
a5c623a
@blampe blampe mentioned this issue Dec 11, 2024
Merged
rshade added a commit that referenced this issue Dec 11, 2024
@rshade
Adding in providertest files for typescript and python, fixes #26
7572d9a
rshade added a commit that referenced this issue Dec 11, 2024
@rshade
Adding in providertest files for typescript and python (#250)
6fc08c2 
This PR adds in simple tests for the two examples currently provided.

Fixes #26
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rshade rshade

Labels
help wanted Extra attention is needed kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding in providertest files for typescript and python pulumi/pulumi-kubernetes-cert-manager
3 participants
@rshade @iwahbe @pulumi-bot