Update eks.md

[omidraha]

Description

Fixed MalformedPolicyDocument error for Python code:

With current python snippet code

assume_role_policy = json.dumps({
    "Version": "2012-10-17",
    "Statement": [{
        "Action": "sts:AssumeRole",
        "Effect": "Allow",
        "Sid": None,
        "Principal": {
            "Service": "ec2.amazonaws.com",
        },
    }],
})

The below MalformedPolicyDocument error raises:

  aws:iam:Role (role1):
    error: 1 error occurred:
    	* creating IAM Role (role1-451c16c): MalformedPolicyDocument: Syntax error at position (1,113)
    	status code: 400, request id: ***

It will be fixed with change Sid argument value from None to the "" an empty string.

Checklist:

• I have reviewed the style guide.
• If blogging, I have reviewed the blogging guide.
• I have manually confirmed that all new links work.
• I added aliases (i.e., redirects) for all filename changes.
• If making css changes, I rebuilt the bundle.

[cnunciato]

Nice catch, thanks @omidraha!

[cnunciato]

@omidraha Since this property is apparently optional, what do you think about omitting it altogether? When I do that, it looks like the policy gets created successfully (and without a Sid) -- and when I then change the Sid to "", Pulumi detects no changes. Is there a benefit (or maybe a best practice?) to using "" as opposed to just leaving the property out?

Suggested change

"Sid": "",

[omidraha]

In the tests related to the library, an empty string has been used as a test case.

You can find an example of this usage at the following link:

https://github.com/pulumi/pulumi-aws/blob/c0dcccb3d7aef5bd661e2f74ec4c5361273d7c12/sdk/python/pulumi_aws/iam/role_policy.py#L191

May be it have been preferred to explicitly include an empty string for clarity in the policy structure.

And also, the record created in the Amazon console will be different.

• 
•