Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding in deleteBeforeReplace as default option, fixes #73 #2586

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Adding in deleteBeforeReplace as default option, fixes #73 #2586

merged 1 commit into from
Nov 7, 2024

Conversation

rshade
Copy link
Contributor

@rshade rshade commented Nov 6, 2024 •
edited by iwahbe
Loading

fixes #73

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@rshade rshade requested a review from a team November 6, 2024 21:21
@iwahbe iwahbe added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Nov 7, 2024
@iwahbe iwahbe merged commit 4fd50a5 into master Nov 7, 2024
24 checks passed
@iwahbe iwahbe deleted the rshade/dbr-es branch November 7, 2024 12:00
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v8.8.0.

@pulumi-bot pulumi-bot mentioned this pull request Nov 7, 2024
Open
@t0yv0 t0yv0 mentioned this pull request Nov 8, 2024
Open
t0yv0 added a commit that referenced this pull request Nov 8, 2024
@t0yv0
Revert "Adding in deleteBeforeReplace as default option, fixes #73 (#…
6b56298 
…2586)"

This reverts commit 4fd50a5.
This was referenced Nov 8, 2024
Merged
Open
t0yv0 added a commit that referenced this pull request Nov 8, 2024
@t0yv0
Revert delete before replace changes (#2595)
4b294a0 
Context:

#2596

Revert:

- #2586
- #2588

Affected resources:

- google_compute_global_address
- google_compute_instance
- google_compute_vpn_tunnel
- google_project_iam_member
- google_service_account_iam_member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwahbe iwahbe iwahbe approved these changes

Assignees
No one assigned
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attached disk prevents Instance from being replaced
3 participants
@rshade @pulumi-bot @iwahbe