Fix context bug which could hang forever #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blampe
commented
Jan 26, 2024
| @@ -898,7 +898,7 @@ func processLogLine(jm jsonmessage.JSONMessage, | |||
| info += "failed to parse aux message: " + err.Error() | |||
| } | |||
| if err := (&resp).Unmarshal(infoBytes); err != nil { | |||
| info += "failed to parse aux message: " + err.Error() | |||
| info += "failed to parse info bytes: " + err.Error() | |||
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
rquitales
reviewed
Jan 26, 2024
| // it if it's not.) | ||
| err = syscall.Mkfifo(filepath.Join(dir, "pipe"), 0o666) | ||
| require.NoError(t, err) | ||
|
|
There was a problem hiding this comment.
nit: consider adding an assert here that the file <dir>/pipe is is not fileMode.IsRegular() to make it more obvious that we have an irregular file.
rquitales
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could hang forever if we have irregular file types present, like pipes which never close.
Here we fix the issue by only hashing regular files.
Fixes #614