-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade pulumi/pulumi #945
Conversation
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this probably works, it is not recommended to have the Pulumi version overtake the pulumi version used in the bridge.
I recommend keeping the pu/pu version currently in go.mod and updating the examples files to that.
Also this is somewhere between a missing feature in upgrade-provider
and the setup of the Go tests in this repo:
upgrade-provider
does not detect all go.mod files in the examples- this is because most providers expect a single go.mod file in `examples/, not one per example.
This reverts commit 89eb23b.
Good catch, updated.
Yes, we want behavior analogous to pulumi/ci-mgmt#778 for bridged providers.
I think this is essentially pulumi/upgrade-provider#142 |
@@ -5,7 +5,7 @@ go 1.21 | |||
require ( | |||
github.com/pulumi/pulumi-aws/sdk/v5 v5.30.0 | |||
github.com/pulumi/pulumi-docker/sdk/v4 v4.0.0-alpha.4 | |||
github.com/pulumi/pulumi/sdk/v3 v3.101.1 | |||
github.com/pulumi/pulumi/sdk/v3 v3.99.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Downgrade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you were looking at the changes between revisions, this is upgrading from 3.55 to 3.99.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM then thank you!
Yeah I'm in the process of finishing up the bridge test on 101 pulumi/pulumi-terraform-bridge#1624 - as far as I can tell the p/p codegen version passes all tests, so if you want to make an exception and move forward that's fine with me, but normally we get the p/p dependency bumped automatically through bridge updates which should be coming shortly once I'm done validating the above and clearing any blockers. |
@t0yv0 the problem is the updates aren't comprehensive, see my other comment here #945 (comment) |
Right. I thought you correctly identified the root cause on that we need to hack update-provider a little further. |
Bumps pu/pu across the entire repo, including a few examples that were still using very old versions.