Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect EditDir path in TestAzureContainerRegistry #880

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Dec 11, 2023

Prior to this change, EditPath pointed to a non-existing directory so this test wasn't testing what's expected.. recent versions of Pulumi make this error a hard error; also we probably want the test to actually test the intended state transition encoded in the edit dir, hence this change.

@t0yv0 t0yv0 requested a review from a team December 11, 2023 22:56
Copy link

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@t0yv0 t0yv0 merged commit d39c5b5 into master Dec 12, 2023
18 checks passed
@t0yv0 t0yv0 deleted the t0yv0/fix-edit-dir branch December 12, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants