Add --network and --add-host to Image #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
blampe
commented
Nov 29, 2023
provider/image.go
Outdated
Comment on lines
46
to
49
| const ( | ||
| defaultDockerfile = "Dockerfile" | ||
| defaultBuilder = "2" | ||
| ) |
There was a problem hiding this comment.
Some of the formatting noise here is due to gofumpt (the formatter we use in pu/pu) cleaning things up. I can break this out into a separate change if it's too noisy.
Comment on lines
-104
to
-115
| cache, err := marshalCachedImages(inputs["build"]) | ||
| if err != nil { | ||
| return "", nil, err | ||
| } | ||
|
|
||
| build.CachedImages = cache |
There was a problem hiding this comment.
marshalBuildAndApplyDefaults now handles marshaling and setting CachedImages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
--networkand--add-hostoptions since those are supported by both builders.(Other requests like #761 will require more thought, since that functionality isn't supported in the v1 API we're using right now.)
Two integration tests are included to ensure the behavior with v1 and v2 builders.
While I was in here I also added
platformas an output.Fixes #837.
Fixes #862.