Fix Service replicated/global conflict #864
Conversation
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
| @@ -765,7 +765,6 @@ func resourceDockerService() *schema.Resource { | ||
| "global": { | ||
| Type: schema.TypeBool, | ||
| Description: "The global service mode. Defaults to `false`", |
There was a problem hiding this comment.
We should edit the description here as well.
examples/examples_yaml_test.go
Outdated
There was a problem hiding this comment.
Should we have a test where we do not set the mode at all?
There was a problem hiding this comment.
FWIW this will default to replicated: 1 - added a note in the docs.
There was a problem hiding this comment.
I'm concerned that removing a global default here will result in breaking changes. Have we verified that this is not a concern?
Small clarification - the field is called "global" but it's not a global, it just affects some behavior for this specific Service resource.
Today the resource doesn't work at all if mode is specified, so I'm not concerned.
| master | this PR | |
|---|---|---|
mode: { } |
works (1 replica) | works (1 replica) |
mode: { global: true } |
broken | works |
mode: { replicated: { replicas: 1 } } |
broken | works |
I would also like to see a follow-up issue filed, with a plan to remove this patch once the bridge issue is resolved.
👍 #865
examples/examples_yaml_test.go
Outdated
There was a problem hiding this comment.
FWIW this will default to replicated: 1 - added a note in the docs.
Removes upstream's Service.global default as a workaround for pulumi/pulumi-terraform-bridge#1095.
The included E2E test reproduced the issue locally and now passes with the fix. We'll see if it passes on CI -- GitHub might need some massaging to get a swarm working.
Fixes #401.