Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read docker host from config #574

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Read docker host from config #574

merged 2 commits into from
Mar 30, 2023

Conversation

guineveresaenger
Copy link
Contributor

Because Image is part of the native provider, we need to be able to pass configurations to it as well. This change allows users to set the hostname for the docker host in their configuration file.

Fixes #567.
Closes #51 as well.

Because Image is part of the native provider, we need to be able to pass
configurations to it as well. This change allows users to set the
hostname for the docker host in their configuration file
@guineveresaenger guineveresaenger requested review from jazzyfresh, AaronFriel and a team March 28, 2023 21:31
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link
Contributor

@jazzyfresh jazzyfresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but no test?

@guineveresaenger
Copy link
Contributor Author

I admit I'm not entirely sure how to test that the client created contains certain options...maybe I can just assert no error though. 🤔

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@guineveresaenger guineveresaenger merged commit 8ff68a2 into master Mar 30, 2023
@guineveresaenger guineveresaenger deleted the guin/docker-host branch March 30, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker.Image does not read host value from provider-level config Use package config in docker.Image
2 participants