Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EOF condition to special error case handling #506

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

guineveresaenger
Copy link
Contributor

@guineveresaenger guineveresaenger commented Feb 28, 2023

This pull request adds an extra error handling step to the logging output.
In the case of a docker push to AWS, when credentials are incorrect or mismatched, we sometimes see Docker re-trying a push multiple times, only to ultimately fail with an uninformative error: EOF. This extra condition intercepts this error and adds more detail to the output.

Fixes #485

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@guineveresaenger guineveresaenger merged commit f8b981d into master Mar 2, 2023
@guineveresaenger guineveresaenger deleted the vaildate-eof branch March 2, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pushing to an AWS registry with invalid credentials returns the error "EOF"
2 participants